Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(DSRE-1774) Grant Google Ads access to desktop conv events view #6361

Merged
merged 3 commits into from
Oct 16, 2024
Merged

feat(DSRE-1774) Grant Google Ads access to desktop conv events view #6361

merged 3 commits into from
Oct 16, 2024

Conversation

kwindau
Copy link
Contributor

@kwindau kwindau commented Oct 16, 2024 •
edited by data-sync-user
Loading

Description

This PR is intended to enable the Google ads account to have read access to the view
mozdata.mozilla_org.desktop_conversion_events

Related Tickets & Documents

Reviewer, please follow this checklist

┆Issue is synchronized with this Jira Task

@kwindau kwindau requested a review from whd October 16, 2024 20:32
@kwindau kwindau marked this pull request as ready for review October 16, 2024 20:32
@dataops-ci-bot

This comment has been minimized.

Sign in to view
whd
whd approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@whd whd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any specific knowledge of this system other than what I read from https://support.google.com/google-ads/answer/13763054?hl=en, which I translated into the Jira ticket and which seems to match this PR.

sql/moz-fx-data-shared-prod/mozilla_org/desktop_conversion_events/metadata.yaml Outdated Show resolved Hide resolved
sql/moz-fx-data-shared-prod/mozilla_org/desktop_conversion_events/metadata.yaml Outdated Show resolved Hide resolved
@dataops-ci-bot
Copy link

Integration report for "DSRE-1774 - remove references and other unnecessary metadata"

sql.diff

Click to expand! 
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/mozilla_org/dataset_metadata.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/mozilla_org/dataset_metadata.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/mozilla_org/dataset_metadata.yaml	2024-10-16 21:38:49.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/mozilla_org/dataset_metadata.yaml	2024-10-16 21:38:43.000000000 +0000
@@ -12,3 +12,6 @@
 - role: roles/bigquery.dataViewer
   members:
   - workgroup:mozilla-confidential
+- role: roles/bigquery.metadataViewer
+  members:
+  - workgroup:google-managed/external-ads-dataproc
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/mozilla_org/desktop_conversion_events/metadata.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/mozilla_org/desktop_conversion_events/metadata.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/mozilla_org/desktop_conversion_events/metadata.yaml	2024-10-16 21:39:32.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/mozilla_org/desktop_conversion_events/metadata.yaml	2024-10-16 21:40:10.000000000 +0000
@@ -1,13 +1,11 @@
-friendly_name: Desktop Conversion Events
-description: |-
-  Please provide a description for the query
-owners: []
-labels: {}
-bigquery: null
 workgroup_access:
 - role: roles/bigquery.dataViewer
   members:
   - workgroup:mozilla-confidential
+  - workgroup:external-ads-datafusion
+  - workgroup:external-ads-dataproc
+
+# Generated by bigquery_etl.dependency
 references:
   view.sql:
   - moz-fx-data-shared-prod.mozilla_org_derived.ga_desktop_conversions_v1
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/mozilla_org_derived/ga_desktop_conversions_v1/metadata.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/mozilla_org_derived/ga_desktop_conversions_v1/metadata.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/mozilla_org_derived/ga_desktop_conversions_v1/metadata.yaml	2024-10-16 21:38:49.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/mozilla_org_derived/ga_desktop_conversions_v1/metadata.yaml	2024-10-16 21:38:43.000000000 +0000
@@ -28,3 +28,5 @@
   members:
   - workgroup:dataops-managed/external-census
   - workgroup:mozilla-confidential
+  - workgroup:external-ads-datafusion
+  - workgroup:external-ads-dataproc
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/mozilla_org_derived/ga_sessions_v2/metadata.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/mozilla_org_derived/ga_sessions_v2/metadata.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/mozilla_org_derived/ga_sessions_v2/metadata.yaml	2024-10-16 21:38:49.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/mozilla_org_derived/ga_sessions_v2/metadata.yaml	2024-10-16 21:38:43.000000000 +0000
@@ -29,3 +29,5 @@
   members:
   - workgroup:dataops-managed/external-census
   - workgroup:mozilla-confidential
+  - workgroup:external-ads-datafusion
+  - workgroup:external-ads-dataproc
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/static/country_codes_v1/metadata.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/static/country_codes_v1/metadata.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/static/country_codes_v1/metadata.yaml	2024-10-16 21:38:49.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/static/country_codes_v1/metadata.yaml	2024-10-16 21:38:43.000000000 +0000
@@ -8,3 +8,5 @@
 - role: roles/bigquery.dataViewer
   members:
   - workgroup:dataops-managed/external-census
+  - workgroup:external-ads-datafusion
+  - workgroup:external-ads-dataproc

Link to full diff

@kwindau kwindau added this pull request to the merge queue Oct 16, 2024
Merged via the queue into main with commit 8d17916 Oct 16, 2024
21 checks passed
@kwindau kwindau deleted the DSRE-1774-GOOGLE-ADS-PERMISSIONS branch October 16, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whd whd whd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kwindau @dataops-ci-bot @whd